Technoboy- commented on code in PR #15348:
URL: https://github.com/apache/pulsar/pull/15348#discussion_r862277094
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1042,7 +1042,16 @@ public TopicStats getStats(
@ApiParam(value = "If return time of the earliest message in
backlog")
@QueryParam("getEarliestTimeInBacklog") @DefaultValue("false")
boolean getEarliestTimeInBacklog) {
validateTopicName(tenant, namespace, encodedTopic);
- return internalGetStats(authoritative, getPreciseBacklog,
subscriptionBacklogSize, getEarliestTimeInBacklog);
+ internalGetStatsAsync(authoritative, getPreciseBacklog,
subscriptionBacklogSize, getEarliestTimeInBacklog)
Review Comment:
Hi @nodece , I have checked that `validateTopicName` already throw
RestException, no need to use try/catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
