nodece commented on code in PR #15348:
URL: https://github.com/apache/pulsar/pull/15348#discussion_r862447732
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v1/PersistentTopics.java:
##########
@@ -364,13 +363,24 @@ public void getSubscriptions(@Suspended final
AsyncResponse asyncResponse, @Path
@ApiResponses(value = {
@ApiResponse(code = 307, message = "Current broker doesn't serve
the namespace of this topic"),
@ApiResponse(code = 403, message = "Don't have admin permission"),
- @ApiResponse(code = 404, message = "Topic does not exist") })
- public TopicStats getStats(@PathParam("property") String property,
@PathParam("cluster") String cluster,
+ @ApiResponse(code = 404, message = "Topic does not exist")})
+ public void getStats(
+ @Suspended final AsyncResponse asyncResponse,
+ @PathParam("property") String property, @PathParam("cluster")
String cluster,
@PathParam("namespace") String namespace, @PathParam("topic")
@Encoded String encodedTopic,
@QueryParam("authoritative") @DefaultValue("false") boolean
authoritative,
@QueryParam("getPreciseBacklog") @DefaultValue("false") boolean
getPreciseBacklog) {
validateTopicName(property, cluster, namespace, encodedTopic);
- return internalGetStats(authoritative, getPreciseBacklog, false,
false);
+ internalGetStatsAsync(authoritative, getPreciseBacklog, false, false)
+ .thenAccept(asyncResponse::resume)
+ .exceptionally(ex -> {
+ // If the exception is not redirect exception we need to
log it.
Review Comment:
Keep style with old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
