Jason918 commented on code in PR #15412:
URL: https://github.com/apache/pulsar/pull/15412#discussion_r863791834
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/RocksdbMetadataStore.java:
##########
@@ -220,6 +223,8 @@ private RocksdbMetadataStore(String metadataURL,
MetadataStoreConfig metadataSto
Path dataPath = FileSystems.getDefault().getPath(dataDir);
try {
Files.createDirectories(dataPath);
+ Set<PosixFilePermission> perms =
PosixFilePermissions.fromString("rwx------");
Review Comment:
Not in the scope of this PR.
##########
pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java:
##########
@@ -75,6 +79,7 @@ static File doUnpackNar(final File nar, final File
baseWorkingDirectory, Runnabl
throw new IOException("Cannot create " + parentDirectory);
}
}
+ setPosixFilePermissions(parentDirectory,"rwxr-x---");
Review Comment:
This only need to set after `mkdirs`.
It's better to create a new method like `makeDirs(File)` and set permission
there.
##########
pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java:
##########
@@ -75,6 +79,7 @@ static File doUnpackNar(final File nar, final File
baseWorkingDirectory, Runnabl
throw new IOException("Cannot create " + parentDirectory);
}
}
+ setPosixFilePermissions(parentDirectory,"rwxr-x---");
Review Comment:
This only need to set after `mkdirs`.
It's better to create a new method like `makeDirs(File)` and set permission
there.
##########
pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java:
##########
@@ -87,6 +92,7 @@ static File doUnpackNar(final File nar, final File
baseWorkingDirectory, Runnabl
FileLock lock = channel.lock()) {
File narWorkingDirectory = new File(parentDirectory, md5Sum);
if (narWorkingDirectory.mkdir()) {
+ setPosixFilePermissions(narWorkingDirectory,"rwxr-x---");
Review Comment:
And please check code format.
##########
pulsar-common/src/main/java/org/apache/pulsar/common/nar/NarUnpacker.java:
##########
@@ -87,6 +92,7 @@ static File doUnpackNar(final File nar, final File
baseWorkingDirectory, Runnabl
FileLock lock = channel.lock()) {
File narWorkingDirectory = new File(parentDirectory, md5Sum);
if (narWorkingDirectory.mkdir()) {
+ setPosixFilePermissions(narWorkingDirectory,"rwxr-x---");
Review Comment:
And please check code format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
