skysiders commented on PR #15412: URL: https://github.com/apache/pulsar/pull/15412#issuecomment-1126904510
> > Yes it's better to add UT here.But the method is private it is not easy to write UT here.Could I change new method to public?Because it seem has no impact here if new method is public. > > You can checkout `@VisibleForTesting` for reference. Hi @Jason918 ,Thanks for your review. I try to use`@VisibleForTesting` and add UT to test new method in this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
