BewareMyPower commented on PR #15413: URL: https://github.com/apache/pulsar/pull/15413#issuecomment-1119587783
The initial purpose of this PR was that I'm wondering why adding a `KeyedBatch` class in `BatchMessageKeyBasedContainer` rather than reusing the `BatchMessageContainerImpl`. Then I found the difference that `BatchMessageKeyBasedContainer` 1. doesn't update the `ProducerImpl#lastSequenceIdPushed` 2. sort the batches by sequence id, not highest sequence id So during the refactoring, I tend to adopt the more correct behavior rather than keeping the previous behavior (might not be on purpose, but a mistake). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
