BewareMyPower commented on code in PR #15413:
URL: https://github.com/apache/pulsar/pull/15413#discussion_r867356275


##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationTest.java:
##########
@@ -46,7 +64,7 @@ protected void cleanup() throws Exception {
         super.internalCleanup();
     }
 
-    @Test
+    @Test(priority = -1)

Review Comment:
   We need to run `testNamespaceDeduplicationApi` before all other tests 
because it assumes the initial duplication status is null.
   
   ```java
       public void testNamespaceDeduplicationApi() throws Exception {
           final String namespace = "my-property/my-ns";
           assertNull(admin.namespaces().getDeduplicationStatus(namespace));
   ```
   
   After `testKeyBasedBatchingOrder` is added, `testNamespaceDeduplicationApi` 
will run after `testKeyBasedBatchingOrder`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to