Jason918 commented on code in PR #14971: URL: https://github.com/apache/pulsar/pull/14971#discussion_r867441942
########## conf/broker.conf: ########## @@ -1144,6 +1144,10 @@ defaultNamespaceBundleSplitAlgorithm=range_equally_divide # load shedding strategy, support OverloadShedder and ThresholdShedder, default is ThresholdShedder since 2.10.0 loadBalancerLoadSheddingStrategy=org.apache.pulsar.broker.loadbalance.impl.ThresholdShedder +# load balance load manager strategy, support LeastLongTermMessageRate and ThresholdLoadManagerStrategy, +# default is LeastLongTermMessageRate +loadBalancerLoadManagerStrategy=org.apache.pulsar.broker.loadbalance.impl.LeastLongTermMessageRate Review Comment: > I wonder if it is better to let the user only configure the classname without the package name, this way we will prevent users to load non-standard classes. +1, good point -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
