shibd opened a new pull request, #15491: URL: https://github.com/apache/pulsar/pull/15491
### Motivation The current source ack type and `ProcessingGuarantees` are forcibly bound together, This is not flexible for implementing a new sink. If sink is Guarantees equals `ATMOST_ONCE`, it can't be use `acknowledgeCumulative` https://github.com/apache/pulsar/blob/a0dcab679b1842a2efee4df2f31bf41ef5ab1dd0/pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/source/PulsarSource.java#L136-L142 ### Modifications - Provide an `ack(boolean cumulative)` method to support the sink to select the ack type ### Documentation - [x] `no-need-doc` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
