michaeljmarshall commented on code in PR #14858:
URL: https://github.com/apache/pulsar/pull/14858#discussion_r868326251
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java:
##########
@@ -577,11 +577,9 @@ protected void
internalCreatePartitionedTopic(AsyncResponse asyncResponse, int n
Policies policies = getNamespacePolicies(namespaceName);
maxTopicsPerNamespace = policies.max_topics_per_namespace;
} catch (RestException e) {
- if (e.getResponse().getStatus() !=
Status.NOT_FOUND.getStatusCode()) {
- log.error("[{}] Failed to create partitioned topic {}",
clientAppId(), namespaceName, e);
- resumeAsyncResponseExceptionally(asyncResponse, e);
- return;
- }
+ log.error("[{}] Failed to create partitioned topic {}",
clientAppId(), namespaceName, e);
Review Comment:
I think this is technically different than the v1 vs v2 problem. In this
case, we're failing topic creation if getting the namespace policies fails. I
think this proposed behavior is correct, since we wouldn't want to exceed the
`maxTopicsPerNamespace` just because getting the namespace policies failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
