michaeljmarshall commented on code in PR #14858:
URL: https://github.com/apache/pulsar/pull/14858#discussion_r868825453
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/AdminResource.java:
##########
@@ -577,11 +577,9 @@ protected void
internalCreatePartitionedTopic(AsyncResponse asyncResponse, int n
Policies policies = getNamespacePolicies(namespaceName);
maxTopicsPerNamespace = policies.max_topics_per_namespace;
} catch (RestException e) {
- if (e.getResponse().getStatus() !=
Status.NOT_FOUND.getStatusCode()) {
- log.error("[{}] Failed to create partitioned topic {}",
clientAppId(), namespaceName, e);
- resumeAsyncResponseExceptionally(asyncResponse, e);
- return;
- }
+ log.error("[{}] Failed to create partitioned topic {}",
clientAppId(), namespaceName, e);
Review Comment:
Upon re-review, my comment is not correct. The previous code was only
skipping NOT_FOUND status codes. All other errors are propagated correctly, so
the only case that a topic is created when it "shouldn't be" is when the
namespace policies are not found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
