horizonzy commented on code in PR #15063:
URL: https://github.com/apache/pulsar/pull/15063#discussion_r868937456
##########
tiered-storage/jcloud/src/main/java/org/apache/bookkeeper/mledger/offload/jcloud/impl/BlockAwareSegmentInputStreamImpl.java:
##########
@@ -161,6 +212,45 @@ private List<ByteBuf> readNextEntriesFromLedger(long
start, long maxNumberEntrie
}
}
+ @Override
+ public int read(byte[] b, int off, int len) throws IOException {
+ if (b == null) {
+ throw new NullPointerException("The given bytes are null");
+ } else if (off < 0 || len < 0 || len > b.length - off) {
+ throw new IndexOutOfBoundsException("off=" + off + ", len=" + len
+ ", b.length=" + b.length);
+ } else if (len == 0) {
+ return 0;
+ }
+
+ int offset = off;
+ int readLen = len;
+ int readBytes = 0;
+ // reading header
+ if (dataBlockHeaderStream.available() > 0) {
+ int read = dataBlockHeaderStream.read(b, off, len);
+ offset += read;
+ readLen -= read;
+ readBytes += read;
+ bytesReadOffset += read;
Review Comment:
~~Maybe `bytesReadOffset` should not increase, relation:
https://github.com/apache/pulsar/pull/15063/files?diff=split&w=0#r86888317~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
