eolivelli commented on code in PR #15503:
URL: https://github.com/apache/pulsar/pull/15503#discussion_r872229670
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdPersistentTopics.java:
##########
@@ -507,8 +512,23 @@ void run() throws PulsarAdminException {
} else {
messageId = validateMessageIdString(messageIdStr);
}
-
- getPersistentTopics().createSubscription(persistentTopic,
subscriptionName, messageId);
+ Map<String, String> map = new HashMap<>();
+ if (properties != null) {
+ for (String property : properties) {
+ if (!property.contains("=")) {
Review Comment:
this was copy/paste code, I have consolidated all duplicate code in one
single method and addressed your comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
