315157973 commented on code in PR #15503:
URL: https://github.com/apache/pulsar/pull/15503#discussion_r873138817
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java:
##########
@@ -1456,7 +1460,9 @@ public void createSubscription(
)
ResetCursorData resetCursorData,
@ApiParam(value = "Is replicated required to perform this
operation")
- @QueryParam("replicated") boolean replicated
+ @QueryParam("replicated") boolean replicated,
+ @ApiParam(value = "JSON encoded list of properties for the
Subscription")
+ @QueryParam("properties") String properties
Review Comment:
Should we put it in the body? The url is too long and prone to truncation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
