michaeljmarshall commented on code in PR #15576:
URL: https://github.com/apache/pulsar/pull/15576#discussion_r872634779
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java:
##########
@@ -267,6 +267,48 @@ public void
revokePermissionOnSubscription(@PathParam("property") String propert
internalRevokePermissionsOnSubscription(subscription, role);
}
+ @PUT
Review Comment:
I noticed the other grant endpoints use `POST`, but it seems like the wrong
rest method because these grant operations are idempotent. I can switch to
`POST` to be consistent, but I think it's more correct to use `PUT`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
