michaeljmarshall commented on code in PR #15576:
URL: https://github.com/apache/pulsar/pull/15576#discussion_r872662757
##########
pulsar-common/src/main/java/org/apache/pulsar/client/admin/internal/data/AuthPoliciesImpl.java:
##########
@@ -42,6 +42,10 @@ public final class AuthPoliciesImpl implements AuthPolicies {
@JsonProperty("subscription_auth_roles")
private Map<String, Set<String>> subscriptionAuthentication = new
TreeMap<>();
+ // Default value is set in the builder
+ @JsonProperty(value = "implicit_subscription_auth")
+ private boolean implicitSubscriptionAuth;
Review Comment:
@eolivelli - on second thought, are you suggesting that I need to update the
variable names or just that the stored metadata needs to default to false? The
semantics of "granting permission" on the API will be different if we change
the endpoint names to align with a default value where "false" means additional
permission is granted roles. For example, an alternate name for the
`/implicitPermissionOnSubscription` endpoint is
`/permissionOnSubscriptionRequired`. In that case, granting permission would
use a `PUT`/`POST` to set the value to false, which seems counter intuitive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
