michaeljmarshall opened a new pull request, #15763:
URL: https://github.com/apache/pulsar/pull/15763

   ### Motivation
   
   Enable pass through configuration support for the bookkeeper clients created 
by `DistributedLog` and `BookKeeperPackagesStorage`. This support is already 
present for the managed ledger bookkeeper client, which takes all `bookkeeper_` 
prefixed configs. In order to simplify configuration, I reused the 
`bookkeeper_` prefix since it's reasonable to assume that these configs will be 
the same.
   
   ### Modifications
   
   * Create `PulsarConfigurationUtils` class to reduce code duplication for 
mapping prefixed config classes into other config classes. This class is not 
available in the `pulsar-package-management` module, so the code is copied. I 
don't think we should expose this code in the client jars.
   * Update the `BookKeeperPackagesStorageConfiguration` to expose the 
underlying `properties` object.
   * Add documentation to the `broker.conf` and the `functions_worker.yml` 
files.
   
   ### Verifying this change
   
   I added tests to ensure that the new methods work as expected.
   
   ### Does this pull request potentially affect one of the following parts:
   
   This is a backwards compatible change. The only nuance is that the package 
management dlog bookie client will inherit the same configs that the broker 
already uses for the bookie client. I think this is preferable.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to