Anonymitaet commented on code in PR #15763: URL: https://github.com/apache/pulsar/pull/15763#discussion_r881141844
########## conf/broker.conf: ########## @@ -1429,6 +1432,10 @@ packagesReplicas=1 # The bookkeeper ledger root path packagesManagementLedgerRootPath=/ledgers +# When using BookKeeperPackagesStorageProvider, you can configure the +# bookkeeper client by prefixing configurations with "bookkeeper_". +# This config will apply to managed ledger bookkeeper clients, as well. Review Comment: ```suggestion # This configuration applies to managed ledger bookkeeper clients as well. ``` ########## conf/broker.conf: ########## @@ -950,8 +950,11 @@ managedLedgerDefaultAckQuorum=2 # in case of lack of enough bookies #bookkeeper_opportunisticStriping=false -# you can add other configuration options for the BookKeeper client -# by prefixing them with bookkeeper_ +# You can add other configuration options for the BookKeeper client +# by prefixing them with "bookkeeper_". These configurations will be applied Review Comment: ```suggestion # by prefixing them with "bookkeeper_". These configurations are applied ``` Write in the simple present tense as much as possible if you are covering facts that were, are, and forever shall be true. https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.e8uqh1awkcnp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
