[GitHub] [pulsar] eolivelli commented on a diff in pull request #15757: Issue 15750: PIP-105: Store Subscription properties

[GitBox]

eolivelli commented on code in PR #15757:
URL: https://github.com/apache/pulsar/pull/15757#discussion_r882491365


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java:
##########
@@ -1094,6 +1093,20 @@ public Map<String, String> getSubscriptionProperties() {
         return subscriptionProperties;
     }
 
+    @Override
+    public CompletableFuture<Void> updateSubscriptionProperties(Map<String, 
String> subscriptionProperties) {
+        Map<String, String> newSubscriptionProperties;
+        if (subscriptionProperties == null || 
subscriptionProperties.isEmpty()) {
+            newSubscriptionProperties = Collections.emptyMap();
+        } else {
+            newSubscriptionProperties = 
Collections.unmodifiableMap(subscriptionProperties);
+        }
+        return cursor.setCursorProperties(newSubscriptionProperties)
+                .thenRun(() -> {
+                    this.subscriptionProperties = newSubscriptionProperties;

Review Comment:
   good catch. I added volatile only on NonPersistentSubscription and I missed 
it here.
   Fixed, thank you @lhotari 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org