lgxbslgx commented on code in PR #16008:
URL: https://github.com/apache/pulsar/pull/16008#discussion_r895148678
##########
conf/pulsar_env.sh:
##########
@@ -60,6 +60,10 @@ for token in $("$JAVA_BIN" -version 2>&1 | grep 'version
"'); do
JAVA_MAJOR_VERSION=${BASH_REMATCH[1]}
fi
break
+ elif [[ $token =~ \"([[:digit:]]+)(.*)\" ]]; then
Review Comment:
> I think it's better to include -internal as part of the pattern to make
this explicit.
I suspect whether there are other special versions, so I use this loose
pattern which only identities the first digit number. I don't think it is good
to restrict it as `-internal`. But I will adjust the code if @lhotari insists
his opinion after second thought.
> The version parsing logic is also duplicated in bkenv.sh. That would need
to be addressed too.
I will address `bkenv.sh` soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
