lgxbslgx commented on code in PR #16008:
URL: https://github.com/apache/pulsar/pull/16008#discussion_r895671920
##########
conf/pulsar_env.sh:
##########
@@ -60,6 +60,10 @@ for token in $("$JAVA_BIN" -version 2>&1 | grep 'version
"'); do
JAVA_MAJOR_VERSION=${BASH_REMATCH[1]}
fi
break
+ elif [[ $token =~ \"([[:digit:]]+)(.*)\" ]]; then
Review Comment:
From the standard, I find the pattern
`\"([[:digit:]]+)\.([[:digit:]]+)\.(.*)\"` can't handle the version like
`1.9-XXX`. I remove the unnecessary latest dot `\.`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
