codelipenghui commented on code in PR #16014:
URL: https://github.com/apache/pulsar/pull/16014#discussion_r895626778
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1418,12 +1418,13 @@ public synchronized PulsarClient getClient() throws
PulsarServerException {
ClientConfigurationData conf =
ConfigurationDataUtils.loadData(overrides,
initialConf, ClientConfigurationData.class);
- conf.setServiceUrl(this.getConfiguration().isTlsEnabled()
- ? this.brokerServiceUrlTls :
this.brokerServiceUrl);
-
conf.setTlsAllowInsecureConnection(this.getConfiguration().isTlsAllowInsecureConnection());
-
conf.setTlsTrustCertsFilePath(this.getConfiguration().getTlsCertificateFilePath());
+ boolean tlsEnabled =
this.getConfiguration().isBrokerClientTlsEnabled();
Review Comment:
@nodece Could you please provide more details of `No breaking changes.`?
Without this change, `this.getConfiguration().isTlsEnabled()` will be used to
create the broker client. But after this change, users must configure
`brokerClientTlsEnabled`, what will happen if `brokerClientTlsEnabled` absents?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
