nodece commented on code in PR #16014:
URL: https://github.com/apache/pulsar/pull/16014#discussion_r896310678
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1418,12 +1418,13 @@ public synchronized PulsarClient getClient() throws
PulsarServerException {
ClientConfigurationData conf =
ConfigurationDataUtils.loadData(overrides,
initialConf, ClientConfigurationData.class);
- conf.setServiceUrl(this.getConfiguration().isTlsEnabled()
- ? this.brokerServiceUrlTls :
this.brokerServiceUrl);
-
conf.setTlsAllowInsecureConnection(this.getConfiguration().isTlsAllowInsecureConnection());
-
conf.setTlsTrustCertsFilePath(this.getConfiguration().getTlsCertificateFilePath());
+ boolean tlsEnabled =
this.getConfiguration().isBrokerClientTlsEnabled();
Review Comment:
> @nodece - is your point that since `tlsEnabled` is broken, we don't need
to support it?
Yes, I want to using `this.getConfiguration().isBrokerClientTlsEnabled()`
for keep same with create admin client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
