lhotari commented on code in PR #16033:
URL: https://github.com/apache/pulsar/pull/16033#discussion_r896447899
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java:
##########
@@ -312,15 +312,9 @@ private CompletableFuture<Void>
doIndividualBatchAck(BatchMessageIdImpl batchMes
return this.currentIndividualAckFuture;
} finally {
this.lock.readLock().unlock();
- if (pendingIndividualBatchIndexAcks.size() >=
MAX_ACK_GROUP_SIZE) {
- flush();
- }
}
} else {
doIndividualBatchAckAsync(batchMessageId);
- if (pendingIndividualBatchIndexAcks.size() >= MAX_ACK_GROUP_SIZE) {
- flush();
- }
Review Comment:
This change doesn't match the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
