nodece commented on code in PR #15568:
URL: https://github.com/apache/pulsar/pull/15568#discussion_r896513355
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -939,7 +953,7 @@ public void operationComplete() {
cursor.setActive();
// Update the ack position (ignoring entries that were written
while the cursor was being created)
cursor.initializeCursorPosition(initialPosition ==
InitialPosition.Latest ? getLastPositionAndCounter()
Review Comment:
initializeCursorPosition will read the next valid position from this
position, so I think to handle this is better in initializeCursorPosition.
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/NonDurableCursorImpl.java:
##########
@@ -48,39 +46,46 @@ public class NonDurableCursorImpl extends ManagedCursorImpl
{
// Start from last entry
switch (initialPosition) {
case Latest:
-
initializeCursorPosition(ledger.getLastPositionAndCounter());
+
initializeCursorPosition(ledger.getLastPositionAndCounter(), inclusive);
Review Comment:
initializeCursorPosition will read the next valid position from this
position, so I think to handle this is better in initializeCursorPosition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
