nodece commented on code in PR #15568:
URL: https://github.com/apache/pulsar/pull/15568#discussion_r896520651
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/NonDurableCursorImpl.java:
##########
@@ -48,39 +46,46 @@ public class NonDurableCursorImpl extends ManagedCursorImpl
{
// Start from last entry
switch (initialPosition) {
case Latest:
-
initializeCursorPosition(ledger.getLastPositionAndCounter());
+
initializeCursorPosition(ledger.getLastPositionAndCounter(), inclusive);
break;
case Earliest:
-
initializeCursorPosition(ledger.getFirstPositionAndCounter());
+
initializeCursorPosition(ledger.getFirstPositionAndCounter(), inclusive);
break;
}
} else if (startCursorPosition.getLedgerId() ==
PositionImpl.EARLIEST.getLedgerId()) {
// Start from invalid ledger to read from first available entry
-
recoverCursor(ledger.getPreviousPosition(ledger.getFirstPosition()));
+ recoverCursor(ledger.getFirstPosition(), inclusive);
} else {
// Since the cursor is positioning on the mark-delete position, we
need to take 1 step back from the desired
// read-position
- recoverCursor(startCursorPosition);
+ recoverCursor(startCursorPosition, inclusive);
Review Comment:
Looks we only support reading from Earliest/Latest position, so I don't
think it's necessary to add this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
