codelipenghui commented on code in PR #16399:
URL: https://github.com/apache/pulsar/pull/16399#discussion_r914339409


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java:
##########
@@ -48,6 +53,9 @@ class OpReadEntry implements ReadEntriesCallback {
     public static OpReadEntry create(ManagedCursorImpl cursor, PositionImpl 
readPositionRef, int count,
             ReadEntriesCallback callback, Object ctx, PositionImpl 
maxPosition) {
         OpReadEntry op = RECYCLER.get();
+        if (createCount != null) {

Review Comment:
   Maybe we can try to recycle the OpReadEntry again in the test to confirm the 
OpReadEntry is recycled? So that we don't need to introduce this operation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to