BewareMyPower commented on code in PR #16399:
URL: https://github.com/apache/pulsar/pull/16399#discussion_r914357537
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java:
##########
@@ -48,6 +53,9 @@ class OpReadEntry implements ReadEntriesCallback {
public static OpReadEntry create(ManagedCursorImpl cursor, PositionImpl
readPositionRef, int count,
ReadEntriesCallback callback, Object ctx, PositionImpl
maxPosition) {
OpReadEntry op = RECYCLER.get();
+ if (createCount != null) {
Review Comment:
I just removed the `volatile` instead. In non-testing cases, these two
variables are always null and never changed and we don't have to guarantee the
visibility. Now, the overhead is just a conditional check on normal variables,
just like `if (log.isDebugEnabled())` in other places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
