tisonkun commented on code in PR #16251:
URL: https://github.com/apache/pulsar/pull/16251#discussion_r917764324
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java:
##########
@@ -367,4 +331,49 @@ static void resetLastExitCode() {
lastExitCode = Integer.MIN_VALUE;
}
+ protected void initJCommander() {
Review Comment:
Fair enough. It's a preference about noun. I don't have a strong feeling
here - you're the author and you take the name :)
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java:
##########
@@ -367,4 +331,49 @@ static void resetLastExitCode() {
lastExitCode = Integer.MIN_VALUE;
}
+ protected void initJCommander() {
Review Comment:
Fair enough. It's a preference about verb. I don't have a strong feeling
here - you're the author and you take the name :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
