nicoloboschi commented on code in PR #16251:
URL: https://github.com/apache/pulsar/pull/16251#discussion_r919153702
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/PulsarAdminTool.java:
##########
@@ -43,121 +44,88 @@ public class PulsarAdminTool {
private static int lastExitCode = Integer.MIN_VALUE;
- protected final Map<String, Class<?>> commandMap;
- private final JCommander jcommander;
+ protected Map<String, Class<?>> commandMap;
+ protected JCommander jcommander;
protected final PulsarAdminBuilder adminBuilder;
+ protected RootParams rootParams;
- @Parameter(names = { "--admin-url" }, description = "Admin Service URL to
which to connect.")
- String serviceUrl = null;
+ @Getter
+ public static class RootParams {
- @Parameter(names = { "--auth-plugin" }, description = "Authentication
plugin class name.")
- String authPluginClassName = null;
+ @Parameter(names = { "--admin-url" }, description = "Admin Service URL
to which to connect.")
Review Comment:
This options already exist in `pulsar-admin` so this pull is not the right
place to improve them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
