gaozhangmin commented on code in PR #16357:
URL: https://github.com/apache/pulsar/pull/16357#discussion_r919706859
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java:
##########
@@ -2010,20 +2011,20 @@ private class SetOffloadPolicies extends CliCommand {
@Parameter(names = {"-m", "--maxBlockSizeInBytes"},
description = "ManagedLedger offload max block Size in bytes,"
+ "s3 and google-cloud-storage requires this parameter")
- private int maxBlockSizeInBytes;
+ private String maxBlockSizeInBytesStr;
@Parameter(names = {"-rb", "--readBufferSizeInBytes"},
description = "ManagedLedger offload read buffer size in
bytes,"
+ "s3 and google-cloud-storage requires this parameter")
- private int readBufferSizeInBytes;
+ private String readBufferSizeInBytesStr;
@Parameter(names = {"-t", "--offloadThresholdInBytes"}
, description = "ManagedLedger offload threshold in bytes",
required = true)
- private long offloadThresholdInBytes;
+ private String offloadThresholdInBytesStr;
@Parameter(names = {"-dl", "--offloadDeletionLagInMillis"}
, description = "ManagedLedger offload deletion lag in bytes")
- private Long offloadDeletionLagInMillis;
+ private String offloadDeletionLagInMillisStr;
Review Comment:
We'd better make this parameters and their desc unified with CmdNamespaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
