cckellogg commented on a change in pull request #4108: [pulsar-clients]Save name, type, properties for KeyValueSchema URL: https://github.com/apache/pulsar/pull/4108#discussion_r277829181
########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java ########## @@ -22,6 +22,7 @@ import java.nio.ByteBuffer; +import com.google.gson.Gson; Review comment: Can this extra dependency be removed? The client already shades a json library from pulsar-common and we should use that here and try to avoid extra dependencies. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
