cckellogg commented on a change in pull request #4108: [pulsar-clients]Save name, type, properties for KeyValueSchema URL: https://github.com/apache/pulsar/pull/4108#discussion_r277832319
########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/KeyValueSchema.java ########## @@ -22,6 +22,7 @@ import java.nio.ByteBuffer; +import com.google.gson.Gson; Review comment: @sijie I Didn't realize that there are so many shaded things I guess I missed it. Should we be using the shaded class here so it doesn't potentially clash with user code that imports gson? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
