poorbarcode commented on code in PR #16165:
URL: https://github.com/apache/pulsar/pull/16165#discussion_r931124287
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ClientCnx.java:
##########
@@ -1265,4 +1278,165 @@ private void checkRequestTimeout() {
}
private static final Logger log = LoggerFactory.getLogger(ClientCnx.class);
+
+ /**
+ * Check client connection is now free. This method may change the state
to idle.
+ * This method will not change the state to idle.
+ * @return true if the connection is eligible.
+ */
+ public boolean idleCheck(){
+ if (pendingRequests != null && !pendingRequests.isEmpty()){
+ return false;
+ }
+ if (waitingLookupRequests != null &&
!waitingLookupRequests.isEmpty()){
+ return false;
+ }
+ if (!consumers.isEmpty()){
+ return false;
+ }
+ if (!producers.isEmpty()){
+ return false;
+ }
+ if (!transactionMetaStoreHandlers.isEmpty()){
+ return false;
+ }
+ return true;
+ }
+ /**
Review Comment:
Already fixed, extract `ClientCnxIdleStateManager` to make `ClientCnx` more
simple, you can review this in `ClientCnxIdleStateManager`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
