poorbarcode commented on code in PR #16165:
URL: https://github.com/apache/pulsar/pull/16165#discussion_r931326884


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1440,6 +1440,9 @@ public synchronized PulsarClient getClient() throws 
PulsarServerException {
                 ClientConfigurationData conf =
                         ConfigurationDataUtils.loadData(overrides, 
initialConf, ClientConfigurationData.class);
 
+                // Disabled auto release useless connections
+                conf.setConnectionMaxIdleSeconds(-1);

Review Comment:
   The automatic release connection feature is not yet perfect for transaction 
scenarios, so turn it off first. Here is an example of a TC using a client: 
   
   
https://github.com/apache/pulsar/blob/5df15dd2edd7eeab309fea35828915c8698ea339/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TransactionBufferHandlerImpl.java#L146



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1440,6 +1440,9 @@ public synchronized PulsarClient getClient() throws 
PulsarServerException {
                 ClientConfigurationData conf =
                         ConfigurationDataUtils.loadData(overrides, 
initialConf, ClientConfigurationData.class);
 
+                // Disabled auto release useless connections
+                conf.setConnectionMaxIdleSeconds(-1);

Review Comment:
   The automatic release connection feature is not yet perfect for transaction 
scenarios, so turn it off first. Here is an example of the TC using a client: 
   
   
https://github.com/apache/pulsar/blob/5df15dd2edd7eeab309fea35828915c8698ea339/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/TransactionBufferHandlerImpl.java#L146



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to