[GitHub] [pulsar] Jason918 commented on a diff in pull request #16325: [fix][broker] fix the local police IsolationGroups cover the defaultIsolationGroups when init managedLedger bookkeeper client

Wed, 27 Jul 2022 21:02:22 -0700 


Jason918 commented on code in PR #16325:
URL: https://github.com/apache/pulsar/pull/16325#discussion_r931761022


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/BookKeeperClientFactoryImpl.java:
##########
@@ -234,6 +232,13 @@ private void 
setEnsemblePlacementPolicy(ClientConfiguration bkConf, ServiceConfi
                     NET_TOPOLOGY_SCRIPT_FILE_NAME_KEY,
                     ""));
         }
+
+        if (conf.getBookkeeperClientIsolationGroups() != null && 
!conf.getBookkeeperClientIsolationGroups().isEmpty()) {

Review Comment:
   We can use `StringUtils.isNotBlank` instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to