poorbarcode commented on PR #16758:
URL: https://github.com/apache/pulsar/pull/16758#issuecomment-1205427253
Hi @asafm
> I don't understand this entire explanation. Why does a metric indicating
you flushed due to accepting a single large record obscure anything?
These comments are mainly to describe this:
For E.g. we write these data:
```java
// max batch size = 100, max batch records = 5, max delay = 10 milliseconds
write data_01{ size = 2}
write data_02{ size = 2}
write data_03{ size = 2}
write data_04{ size = 2}
write data_05{ size = 2}
write data_06{ size = 111}
```
We have two plans of metrics: include `data_06` or not.
- Exclude `data_06`
- avg ( batch records count ) = 5
- avg ( batch size) = 10
- Include `data_06`
- avg ( batch records count ) = 3
- avg ( batch size) = 60
The first plan(exclude data_06) presents metrics that make more sense for
adjusting the threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
