tjiuming commented on code in PR #16932:
URL: https://github.com/apache/pulsar/pull/16932#discussion_r940967398
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/SubscriptionStatsTest.java:
##########
@@ -134,4 +144,123 @@ public void testNonContiguousDeletedMessagesRanges()
throws Exception {
.getNonContiguousDeletedMessagesRangesSerializedSize() >
0);
});
}
+
+ @DataProvider(name = "testSubscriptionMetrics")
+ public Object[][] topicAndSubscription() {
+ return new Object[][]{
+ {"persistent://my-property/my-ns/testSubscriptionStats-" +
UUID.randomUUID(), "my-sub1", true},
+ {"non-persistent://my-property/my-ns/testSubscriptionStats-" +
UUID.randomUUID(), "my-sub2", true},
+ {"persistent://my-property/my-ns/testSubscriptionStats-" +
UUID.randomUUID(), "my-sub3", false},
+ {"non-persistent://my-property/my-ns/testSubscriptionStats-" +
UUID.randomUUID(), "my-sub4", false},
+ };
+ }
+
+ @Test(dataProvider = "testSubscriptionMetrics")
+ public void testSubscriptionStats(final String topic, final String
subName, boolean enableTopicStats)
+ throws Exception {
+ @Cleanup
+ Producer<String> producer = pulsarClient.newProducer(Schema.STRING)
+ .topic(topic)
+ .enableBatching(false)
+ .create();
+
+ @Cleanup
+ Consumer<String> consumer = pulsarClient.newConsumer(Schema.STRING)
+ .topic(topic)
+ .subscriptionType(SubscriptionType.Exclusive)
+ .subscriptionName(subName)
+ .subscribe();
+
+ boolean isPersistent = pulsar.getBrokerService().getTopic(topic,
false).get().get().isPersistent();
+ Dispatcher dispatcher = pulsar.getBrokerService().getTopic(topic,
false).get()
+ .get().getSubscription(subName).getDispatcher();
+
+ Field field =
EntryFilterSupport.class.getDeclaredField("entryFilters");
+ field.setAccessible(true);
+ NarClassLoader narClassLoader = mock(NarClassLoader.class);
+ EntryFilter filter1 = new EntryFilterTest();
+ EntryFilterWithClassLoader loader1 =
spyWithClassAndConstructorArgs(EntryFilterWithClassLoader.class, filter1,
narClassLoader);
+ field.set(dispatcher, ImmutableList.of(loader1));
+
+ for (int i = 0; i < 100; i++) {
+ producer.newMessage().property("ACCEPT", "
").value(UUID.randomUUID().toString()).send();
+ }
+ for (int i = 0; i < 100; i++) {
+ producer.newMessage().property("REJECT", "
").value(UUID.randomUUID().toString()).send();
+ }
+ for (int i = 0; i < 100; i++) {
+ producer.newMessage().property("RESCHEDULE", "
").value(UUID.randomUUID().toString()).send();
+ }
+
+ for (;;) {
+ Message<String> message = consumer.receive(10, TimeUnit.SECONDS);
+ if (message == null) {
+ break;
+ }
+ consumer.acknowledge(message);
+ }
+
+ ByteArrayOutputStream output = new ByteArrayOutputStream();
+ PrometheusMetricsGenerator.generate(pulsar, enableTopicStats, false,
false, output);
+ String metricsStr = output.toString();
+ Multimap<String, PrometheusMetricsTest.Metric> metrics =
PrometheusMetricsTest.parseMetrics(metricsStr);
+
+ Collection<PrometheusMetricsTest.Metric> throughFilterMetrics =
+ metrics.get("pulsar_subscription_through_filter_msg_count");
+ Collection<PrometheusMetricsTest.Metric> acceptedMetrics =
+ metrics.get("pulsar_subscription_filter_accepted_msg_count");
+ Collection<PrometheusMetricsTest.Metric> rejectedMetrics =
+ metrics.get("pulsar_subscription_filter_rejected_msg_count");
+ Collection<PrometheusMetricsTest.Metric> rescheduledMetrics =
+
metrics.get("pulsar_subscription_filter_rescheduled_msg_count");
+
+ if (enableTopicStats) {
+ Assert.assertTrue(throughFilterMetrics.size() > 0);
+ Assert.assertTrue(acceptedMetrics.size() > 0);
+ Assert.assertTrue(rejectedMetrics.size() > 0);
+ Assert.assertTrue(rescheduledMetrics.size() > 0);
+
+ double throughFilter = throughFilterMetrics.stream()
+ .filter(m -> m.tags.get("subscription").equals(subName) &&
m.tags.get("topic").equals(topic))
+ .mapToDouble(m-> m.value).sum();
+ double filterAccepted = acceptedMetrics.stream()
+ .filter(m -> m.tags.get("subscription").equals(subName) &&
m.tags.get("topic").equals(topic))
+ .mapToDouble(m-> m.value).sum();
+ double filterRejected = rejectedMetrics.stream()
+ .filter(m -> m.tags.get("subscription").equals(subName) &&
m.tags.get("topic").equals(topic))
+ .mapToDouble(m-> m.value).sum();
+ double filterRescheduled = rescheduledMetrics.stream()
+ .filter(m -> m.tags.get("subscription").equals(subName) &&
m.tags.get("topic").equals(topic))
+ .mapToDouble(m-> m.value).sum();
+
+ Assert.assertEquals(filterAccepted, 100);
+ if (isPersistent) {
+ Assert.assertEquals(filterRejected, 100);
+ Assert.assertEquals(throughFilter, filterAccepted +
filterRejected + filterRescheduled, 0.01 * throughFilter);
+ }
+ } else {
+ Assert.assertEquals(throughFilterMetrics.size(), 0);
Review Comment:
per-subscription metrics are disabled when
`exposeTopicLevelMetricsInPrometheus=false`, so it has to be 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
