mattisonchao commented on code in PR #17018:
URL: https://github.com/apache/pulsar/pull/17018#discussion_r941920786
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -550,14 +550,15 @@ public final synchronized void
readEntriesComplete(List<Entry> entries, Object c
if (serviceConfig.isDispatcherDispatchMessagesInSubscriptionThread()) {
// setting sendInProgress here, because sendMessagesToConsumers
will be executed
// in a separate thread, and we want to prevent more reads
+ havePendingRead = true;
Review Comment:
Just mark here, we set `havePendingRead` here has a risk if the task in
`dispatchMessagesThread` executor got some problem. the `havePendingRead` will
never be set to false.
But I'm not quite sure if the problem exists because this executor is an
unbounded queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
