michaeljmarshall commented on code in PR #17018:
URL: https://github.com/apache/pulsar/pull/17018#discussion_r942711308
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -93,7 +93,7 @@ public class PersistentDispatcherMultipleConsumers extends
AbstractDispatcherMul
protected volatile PositionImpl minReplayedPosition = null;
protected boolean shouldRewindBeforeReadingOrReplaying = false;
protected final String name;
- protected volatile boolean sendInProgress;
+ protected boolean sendInProgress;
Review Comment:
The usage of `volatile` did not cause a regression. It simply was
unnecessary because `sendInProgress` is only ever updated within the
`synchronized (this)` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
