tjiuming commented on code in PR #17041: URL: https://github.com/apache/pulsar/pull/17041#discussion_r943695129
########## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/stats/MetadataStoreStats.java: ########## @@ -0,0 +1,92 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.metadata.impl.stats; + +import io.prometheus.client.Counter; +import io.prometheus.client.Histogram; +import java.util.concurrent.atomic.AtomicBoolean; + +public final class MetadataStoreStats { + private static final AtomicBoolean INITIALIZED = new AtomicBoolean(false); + private static final double[] BUCKETS = new double[]{1, 3, 5, 10, 20, 50, 100, 200, 500, 1000, 2000, 5000}; + + private final Histogram getOpsLatency; + private final Histogram delOpsLatency; + private final Histogram putOpsLatency; + private final Counter getFailedCounter; + private final Counter delFailedCounter; + private final Counter putFailedCounter; + private final Counter putBytesCounter; + + private MetadataStoreStats() { + getOpsLatency = Histogram.build("pulsar_metadata_store_get_ops_latency", "-") Review Comment: do we need to add unit at the end of metrics' name? then the old code may have to keep consistent with it too, it may comes broken change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
