codelipenghui commented on code in PR #17041: URL: https://github.com/apache/pulsar/pull/17041#discussion_r944063327
########## pulsar-broker/src/test/java/org/apache/pulsar/broker/stats/PrometheusMetricsTest.java: ########## @@ -65,12 +65,7 @@ import org.apache.pulsar.broker.service.persistent.PersistentSubscription; import org.apache.pulsar.broker.service.persistent.PersistentTopic; import org.apache.pulsar.broker.stats.prometheus.PrometheusMetricsGenerator; -import org.apache.pulsar.client.api.Consumer; -import org.apache.pulsar.client.api.MessageRoutingMode; -import org.apache.pulsar.client.api.Producer; -import org.apache.pulsar.client.api.PulsarClient; -import org.apache.pulsar.client.api.PulsarClientException; -import org.apache.pulsar.client.api.SubscriptionType; +import org.apache.pulsar.client.api.*; Review Comment: Please avoid the star import ########## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/stats/MetadataStoreStats.java: ########## @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.metadata.impl.stats; + +import io.prometheus.client.Counter; +import io.prometheus.client.Histogram; +import java.util.concurrent.atomic.AtomicBoolean; + +public final class MetadataStoreStats implements AutoCloseable { + private static final double[] BUCKETS = new double[]{1, 3, 5, 10, 20, 50, 100, 200, 500, 1000, 2000, 5000}; + private static final String LABEL_NAME = "metadata_store_name"; Review Comment: ```suggestion private static final String LABEL_NAME = "name"; ``` Can we just use name? Because the indicator name already have `pulsar_metadata_store` prefix ########## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/stats/MetadataStoreStats.java: ########## @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.metadata.impl.stats; + +import io.prometheus.client.Counter; +import io.prometheus.client.Histogram; +import java.util.concurrent.atomic.AtomicBoolean; + +public final class MetadataStoreStats implements AutoCloseable { + private static final double[] BUCKETS = new double[]{1, 3, 5, 10, 20, 50, 100, 200, 500, 1000, 2000, 5000}; + private static final String LABEL_NAME = "metadata_store_name"; + + private static final Histogram GET_OPS_SUCCEED = Histogram + .build("pulsar_metadata_store_get_ops_latency", "-") Review Comment: It's better to create a prefix `pulsar_metadata_store_`, and can we remove "_ops_"? Just keep the name simple. ########## pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/stats/MetadataStoreStats.java: ########## @@ -0,0 +1,124 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.metadata.impl.stats; + +import io.prometheus.client.Counter; +import io.prometheus.client.Histogram; +import java.util.concurrent.atomic.AtomicBoolean; + +public final class MetadataStoreStats implements AutoCloseable { + private static final double[] BUCKETS = new double[]{1, 3, 5, 10, 20, 50, 100, 200, 500, 1000, 2000, 5000}; + private static final String LABEL_NAME = "metadata_store_name"; + + private static final Histogram GET_OPS_SUCCEED = Histogram + .build("pulsar_metadata_store_get_ops_latency", "-") + .unit("ms") + .buckets(BUCKETS) + .labelNames(LABEL_NAME) + .register(); + private static final Histogram DEL_OPS_SUCCEED = Histogram + .build("pulsar_metadata_store_del_ops_latency", "-") + .unit("ms") + .buckets(BUCKETS) + .labelNames(LABEL_NAME) + .register(); + private static final Histogram PUT_OPS_SUCCEED = Histogram + .build("pulsar_metadata_store_put_ops_latency", "-") + .unit("ms") + .buckets(BUCKETS) + .labelNames(LABEL_NAME) + .register(); + private static final Counter GET_OPS_FAILED = Counter + .build("pulsar_metadata_store_get_ops_failed", "-") + .labelNames(LABEL_NAME) + .register(); + private static final Counter DEL_OPS_FAILED = Counter + .build("pulsar_metadata_store_del_ops_failed", "-") + .labelNames(LABEL_NAME) + .register(); + private static final Counter PUT_OPS_FAILED = Counter + .build("pulsar_metadata_store_put_ops_failed", "-") + .labelNames(LABEL_NAME) + .register(); + private static final Counter PUT_BYTES = Counter + .build("pulsar_metadata_store_put", "-") + .unit("byte") Review Comment: Should be `bytes`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
