AnonHxy commented on code in PR #17206:
URL: https://github.com/apache/pulsar/pull/17206#discussion_r951309253
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -1559,19 +1560,37 @@ protected void
internalSetPersistence(PersistencePolicies persistence) {
private void doUpdatePersistence(PersistencePolicies persistence) {
try {
- updatePolicies(namespaceName, policies -> {
- policies.persistence = persistence;
- return policies;
- });
- log.info("[{}] Successfully updated persistence configuration:
namespace={}, map={}", clientAppId(),
- namespaceName,
jsonMapper().writeValueAsString(persistence));
+
doUpdatePersistenceAsyn(persistence).get(namespaceResources().getOperationTimeoutSec(),
TimeUnit.SECONDS);
Review Comment:
I think the modification of this method is unrelated to this PR, we'd
better do not change it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
