Pomelongan commented on code in PR #17206:
URL: https://github.com/apache/pulsar/pull/17206#discussion_r955826472
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -1572,6 +1572,19 @@ private void doUpdatePersistence(PersistencePolicies
persistence) {
}
}
+ private CompletableFuture<Void>
doUpdatePersistenceAsync(PersistencePolicies persistence) {
+ return updatePoliciesAsync(namespaceName, policies -> {
+ policies.persistence = persistence;
+ return policies;
+ }).thenAccept(__ -> log.info("[{}] Successfully updated persistence
configuration: namespace={}, map={}",
+ clientAppId(), namespaceName, persistence)
+ ).exceptionally(ex -> {
+ log.error("[{}] Failed to update persistence configuration for
namespace {}", clientAppId(), namespaceName,
+ ex);
+ throw new RestException(ex);
Review Comment:
> You can move log logic to v2.
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
