eolivelli commented on PR #17153: URL: https://github.com/apache/pulsar/pull/17153#issuecomment-1227464218
@gaozhangmin thanks for your clarification. it makes sense to me. I have two remaining points: - I don't find tests about configuring the filters "per broker" - I do think that the filters must be "additive" and the namespace/topic filters should not override the broker filters The broker filters may have been set by the system administrator to enforce some rules and if a user (tenant admin?) is able to override the list of filters that that would be some kind of security hole. If you feel strong that we should keep the behaviour of this patch, then I would ask you to add a configuration parameter to make this behaviour configurable, in order to allow system administrators to enforce some entry filters -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
