eolivelli commented on PR #17153: URL: https://github.com/apache/pulsar/pull/17153#issuecomment-1229853336
@gaozhangmin thank you for adding the parameter. The patch now looks generally good. One last comment: we are missing tests for the new option: we need tests that validate that the option is really working. After adding the tests I am +1 to this patch, great work ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
