nicoloboschi commented on code in PR #17062:
URL: https://github.com/apache/pulsar/pull/17062#discussion_r957400269


##########
bin/pulsar:
##########
@@ -257,8 +257,8 @@ if [ -z "$PULSAR_LOG_CONF" ]; then
     PULSAR_LOG_CONF=$DEFAULT_LOG_CONF
 fi
 
-if [ -z "$PULSAR_PRESTO_CONF" ]; then
-    PULSAR_PRESTO_CONF=$DEFAULT_PULSAR_PRESTO_CONF
+if [ -z "$PULSAR_TRINO_CONF" ]; then

Review Comment:
   for better handling retrocompatibility we could still check 
PULSAR_PRESTO_CONF as fallback. something like this:
   
   ```
   if [ -z "$PULSAR_TRINO_CONF" ]; then
     if [ -z "$PULSAR_PRESTO_CONF" ]; then
        PULSAR_TRINO_CONF=$DEFAULT_PULSAR_TRINO_CONF
      else
        PULSAR_TRINO_CONF=$PULSAR_PRESTO_CONF
      fi
   fi
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to