yuruguo commented on code in PR #17337:
URL: https://github.com/apache/pulsar/pull/17337#discussion_r959191631
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -655,6 +655,57 @@ public void updatePropertiesFailed(ManagedLedgerException
exception, Object ctx)
return future;
}
+ protected CompletableFuture<Void> internalRemovePropertiesAsync(boolean
authoritative, String key) {
+ return validateTopicOwnershipAsync(topicName, authoritative)
+ .thenCompose(__ ->
validateNamespaceOperationAsync(topicName.getNamespaceObject(),
+ NamespaceOperation.CREATE_TOPIC))
Review Comment:
I think that the `validateTopicOperationAsync(topicName,
TopicOperation.PRODUCE)` is inappropriate in #17238, because any role with the
`topic produce` action can update the topic‘s properties, in fact only tenant
administrators and users with higher permissions can update it.
So maybe we should open another pr to adjust this permission of #17238.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
