yuruguo commented on code in PR #17337:
URL: https://github.com/apache/pulsar/pull/17337#discussion_r959285750
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -655,6 +655,57 @@ public void updatePropertiesFailed(ManagedLedgerException
exception, Object ctx)
return future;
}
+ protected CompletableFuture<Void> internalRemovePropertiesAsync(boolean
authoritative, String key) {
+ return validateTopicOwnershipAsync(topicName, authoritative)
+ .thenCompose(__ ->
validateNamespaceOperationAsync(topicName.getNamespaceObject(),
+ NamespaceOperation.CREATE_TOPIC))
+ .thenCompose(__ -> {
+ if (topicName.isPartitioned()) {
+ return
internalRemoveNonPartitionedTopicProperties(key);
+ } else {
+ return
pulsar().getBrokerService().fetchPartitionedTopicMetadataAsync(topicName)
+ .thenCompose(metadata -> {
+ if (metadata.partitions == 0) {
+ return
internalRemoveNonPartitionedTopicProperties(key);
+ }
+ return namespaceResources()
+
.getPartitionedTopicResources().updatePartitionedTopicAsync(topicName,
+ p -> {
+
p.properties.remove(key);
+ return new
PartitionedTopicMetadata(p.partitions, p.properties);
Review Comment:
done, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
