nodece commented on code in PR #17338:
URL: https://github.com/apache/pulsar/pull/17338#discussion_r960187424
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -282,7 +289,13 @@ protected void internalDeleteNamespace(AsyncResponse
asyncResponse, boolean auth
log.debug("Found topics on namespace {}", namespaceName);
}
boolean hasNonSystemTopic = false;
- for (String topic : topics) {
+ for (String topic : partitionedTopicNames) {
+ if
(!pulsar().getBrokerService().isSystemTopic(TopicName.get(topic))) {
+ hasNonSystemTopic = true;
+ break;
+ }
+ }
+ for (String topic : topicNames) {
Review Comment:
If `hasNonSystemTopic` is `true`, it is unnecessary here, please add a check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
