sijie commented on a change in pull request #4174: [go function] support
localrun and cluster mode for go function
URL: https://github.com/apache/pulsar/pull/4174#discussion_r279606586
##########
File path:
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java
##########
@@ -198,6 +198,10 @@ void processArguments() throws Exception {
description = "Path to the main Python file/Python Wheel file
for the function (if the function is written in Python)",
listConverter = StringConverter.class)
protected String pyFile;
+ @Parameter(
+ names = "--go",
+ description = "Path to the main Go file for the function (if
the function is written in Go)")
+ protected String goFile;
Review comment:
Nit: I think we are beginning having more and more branches in the pulsar
runtime. I guess it might be the time to do a refactor to make the language
runtime pluggable in Pulsar Function. So that we don't need to touch the
runtime each time we introduce a new language. You don't need to do it right
now. but It might be worth creating a task to track that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
